-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Support dataset aliases #1217
Draft
tatiana
wants to merge
5
commits into
main
Choose a base branch
from
dataset-alias
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tatiana
force-pushed
the
dataset-alias
branch
from
September 23, 2024 11:19
0cc9774
to
46c86a2
Compare
tatiana
force-pushed
the
dataset-alias
branch
from
September 24, 2024 07:41
26ba5f8
to
f2c8cf1
Compare
Lee-W
reviewed
Sep 24, 2024
tatiana
force-pushed
the
dataset-alias
branch
from
September 24, 2024 10:23
04cc589
to
d9bbc02
Compare
…oduce the airflow standalone issue we're experiencing
tatiana
commented
Sep 26, 2024
@@ -145,7 +153,19 @@ def __init__( | |||
self._dbt_runner: dbtRunner | None = None | |||
if self.invocation_mode: | |||
self._set_invocation_methods() | |||
super().__init__(**kwargs) | |||
|
|||
if AIRFLOW_VERSION >= Version("2.10"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only run this if emit_datasets
is set to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, missing tests and validation
Closes: #522
Closes: #1119